Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): use different version of Go #451

Merged
merged 9 commits into from
Aug 10, 2023
Merged

chore(ci): use different version of Go #451

merged 9 commits into from
Aug 10, 2023

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 17, 2023 •
edited
Loading

Runs on go1.20, and go1.21

Updates:

  • actions/setup-go to v4
  • actions/checkout to v3
  • Go to 1.19
  • golangci-lint to v1.54.0

Fixes #449

@ldez ldez force-pushed the feat/improve-ci-workflow branch 3 times, most recently from fe93047 to 34f8f24 Compare July 17, 2023 11:26
@ldez

This comment was marked as outdated.

Sign in to view
@ldez

This comment was marked as outdated.

Sign in to view
@stefanb stefanb mentioned this pull request Jul 21, 2023
Merged
89 tasks
stefanb
stefanb reviewed Aug 3, 2023
View reviewed changes
.github/workflows/go.yml Outdated Show resolved Hide resolved
@ldez ldez mentioned this pull request Aug 9, 2023
Closed
@ldez ldez force-pushed the feat/improve-ci-workflow branch 4 times, most recently from ba5b217 to c196d76 Compare August 9, 2023 20:58
@ldez ldez mentioned this pull request Aug 9, 2023
Merged
@ldez ldez force-pushed the feat/improve-ci-workflow branch from c196d76 to ef9426b Compare August 9, 2023 21:05
@ldez ldez mentioned this pull request Aug 9, 2023
Closed
@ldez ldez force-pushed the feat/improve-ci-workflow branch from 97d1505 to df10188 Compare August 10, 2023 09:26
@ldez ldez force-pushed the feat/improve-ci-workflow branch from df10188 to f1a4c86 Compare August 10, 2023 09:37
@ldez
Copy link
Contributor Author

ldez commented Aug 10, 2023

It works now: https://github.com/ldez/go-ruleguard/actions/runs/5819453620

@cristaloleg
Copy link
Collaborator

Amazing

@ldez
Copy link
Contributor Author

ldez commented Aug 10, 2023

The CI is passed 🎉

@cristaloleg cristaloleg merged commit ecb75df into quasilyte:master Aug 10, 2023
@ldez ldez deleted the feat/improve-ci-workflow branch August 10, 2023 09:50
@cristaloleg
Copy link
Collaborator

Done https://github.com/quasilyte/go-ruleguard/releases/tag/v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasilyte quasilyte quasilyte left review comments

@stefanb stefanb stefanb left review comments

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go1.21: load rules: parse rules file: typechecker error: ...: could not import
4 participants
@ldez @cristaloleg @stefanb @quasilyte